Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove images: remote #12748

Merged
merged 10 commits into from
Jan 19, 2024
Merged

Remove images: remote #12748

merged 10 commits into from
Jan 19, 2024

Conversation

MusicDin
Copy link
Member

Remove default images: remote. I've removed occurrences in docs and replaced some examples with ubuntu*: images.

@ru-fu Should I explain this change in section Remote image servers?
I assume distrobuilder section remains intact for now?

Fixes #12742

@MusicDin MusicDin requested a review from tomponline as a code owner January 18, 2024 19:06
@github-actions github-actions bot added Documentation Documentation needs updating API Changes to the REST API labels Jan 18, 2024
@MusicDin MusicDin force-pushed the fix/rm-remote-images branch from db0b4d9 to f43bad7 Compare January 18, 2024 19:24
Copy link
Contributor

@ru-fu ru-fu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ru-fu Should I explain this change in section Remote image servers?

No, I don't think we need an explanation for it - and if so, it would be in the next release notes, not in the documentation.

I assume distrobuilder section remains intact for now?

Yes, that is still suitable imo.

doc/cloud-init.md Outdated Show resolved Hide resolved
Signed-off-by: Din Music <din.music@canonical.com>
Signed-off-by: Din Music <din.music@canonical.com>
Signed-off-by: Din Music <din.music@canonical.com>
Signed-off-by: Din Music <din.music@canonical.com>
Signed-off-by: Din Music <din.music@canonical.com>
Signed-off-by: Din Music <din.music@canonical.com>
Signed-off-by: Din Music <din.music@canonical.com>
Signed-off-by: Din Music <din.music@canonical.com>
Signed-off-by: Din Music <din.music@canonical.com>
Signed-off-by: Din Music <din.music@canonical.com>
@MusicDin MusicDin force-pushed the fix/rm-remote-images branch from f43bad7 to d4645f6 Compare January 19, 2024 09:31
Copy link
Contributor

@ru-fu ru-fu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs look good! :)

Copy link
Member

@tomponline tomponline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Changes to the REST API Documentation Documentation needs updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the images: remote from the lxc CLI tool
3 participants